Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

跳过提示框提前出现 #99

Merged
merged 16 commits into from
Dec 25, 2024
Merged

跳过提示框提前出现 #99

merged 16 commits into from
Dec 25, 2024

Conversation

hanydd
Copy link
Owner

@hanydd hanydd commented Dec 5, 2024

片段前提前展示弹出提示框
reopened #84
fix #53

@hanydd hanydd mentioned this pull request Dec 5, 2024
1 task
@hanydd hanydd changed the title Advance Skip Notice 跳过提示框提前出现 Dec 5, 2024
@hanydd
Copy link
Owner Author

hanydd commented Dec 5, 2024

@etherfun 后面这个功能的讨论放在这里面吧。
我想的是,尽可能地还是要重构之前的方法,不是直接打补丁,要不然后面更没法维护了。如果能从content.js分离一些功能到对应的模块里就更好了。(我现在已经被各种触发条件和调用搞晕了,只能打个断点一点一点看)
我昨天发现SponsorBlock也更新了一个提前出现提示框的功能, #2086 也可以借鉴一下

@hanydd hanydd force-pushed the feature-advance-notice branch 2 times, most recently from 1c031c5 to c599a1c Compare December 9, 2024 01:32
@hanydd hanydd merged commit 9bde07e into master Dec 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

自动跳过提示框提前出现
2 participants